New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Upgrade just one app #172

Merged
merged 5 commits into from Oct 6, 2017

Conversation

Projects
None yet
4 participants
@zamentur
Contributor

zamentur commented Aug 28, 2017

Problem

Some times user could be suspicious against one app, and don't want to upgrade it

Suggested solution

Add a button to update just an app in the Update view

How to test

This PR is related to the yunohost-api PR YunoHost/yunohost#359
You can test with by upgrading an app.

To be able to upgrade an app, you can change the update_time by editing your apps settings /etc/yunohost/apps/APP/settings.yml

PR Status

Opinion needed

Validation

  • Principle agreement 2/2 : opi, Aleks
  • Quick review 1/1 : Aleks
  • Simple test 1/1 : opi
  • Deep review 1/1: opi
@opi

opi approved these changes Aug 28, 2017

nice idea !

Show outdated Hide outdated src/locales/en.json Outdated
Show outdated Hide outdated src/views/update/update.ms Outdated
@opi

opi approved these changes Aug 29, 2017

Works as desired

@opi

This comment has been minimized.

Show comment
Hide comment
@opi

opi Aug 29, 2017

Contributor

don't know if my tests were deep enough to call it a "deep review", but I think so.

Contributor

opi commented Aug 29, 2017

don't know if my tests were deep enough to call it a "deep review", but I think so.

@alexAubin

Quick review + principle agreement, looks good to me 👍

@Psycojoker Psycojoker merged commit 713a3d5 into unstable Oct 6, 2017

@Psycojoker Psycojoker deleted the enh-add-ability-to-upgrade-one-app branch Oct 6, 2017

@alexAubin alexAubin added this to the 2.7.x milestone Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment