New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run initial checks each time home page is displayed #217

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

alexAubin commented Dec 11, 2018

Problem

Currently, each time the home page is displayed, several "checks" are re-ran such as the existence of at least one user, fetching the security rss feed, and checking diagnosis for meltdown/spectre, and meanwhile the pacman is loading.

This is no big deal on fast servers, but it takes quite some times on slow hardware like ARM board. You easily end up having to wait ~5 seconds to be able to actually do anything.

Solution

Perform checks only the first time home is shown.
Code isn't so pretty but meh can't do much without recoding everything using ES6

@zamentur
Copy link
Contributor

zamentur left a comment

LGTM
Note: if we refresh the page the check will be done again.

@alexAubin alexAubin merged commit b6aa675 into stretch-unstable Dec 18, 2018

@alexAubin alexAubin deleted the dont-run-initial-checks-everytime branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment