New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for featured community apps #225

Open
wants to merge 5 commits into
base: stretch-unstable
from

Conversation

Projects
None yet
1 participant
@maniackcrudelis
Copy link

maniackcrudelis commented Feb 1, 2019

Add support for featured apps (https://forum.yunohost.org/t/about-community-and-official-apps/6372)
For now, it shows a star for each apps marked as Featured in the community list ("featured": true).

I know we discussed about having a tag merging "Featured" and "Unmaintained", but that's actually the first time I work with php and JS ! So I need time to figure that out...

Also, I "tried" to add a filter for featured and official apps. The filter is in the list on the app list. But the filter itself doesn't work for the moment. I don't know why. I really could use some help on that part !

This PR is related to YunoHost/apps#677 for the list itself.

This PR should be merged after YunoHost/doc#927

@maniackcrudelis

This comment has been minimized.

Copy link
Author

maniackcrudelis commented Feb 1, 2019

Ok I give up the idea of making this filter works. I don't know how this is supposed to work, and there's not enough comment in that part of the code to have any idea how it's supposed to works.

maniackcrudelis added some commits Feb 20, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Author

maniackcrudelis commented Feb 20, 2019

Made some change on this PR, following YunoHost/apps#677.

  • Added support for High Quality apps
  • Restrict this flag only for app with a level at 8 or more.
  • Modify Featured apps to be only those with the flag featured. And restrict it only to app with already the flag high_quality
  • Change from a text with a icon to a label.
  • Finally make the filter works, for High Quality only or Featured only.

@maniackcrudelis

This comment has been minimized.

Copy link
Author

maniackcrudelis commented Feb 20, 2019

Now we have also a support of 3 different states for an unmaintained app.

  • 'orphaned'. For unmaintained apps.
  • 'request_help'. For packagers wanted help for an app.
  • 'request_adoption'. For an app which is going to be unmaintained.

Also, I removed the logo to replace it by a colored label. To be more visible.
I had also kept the name of the maintainer, is there's one in the manifest, aside of the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment