New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to GET /version to fetch version #226

Merged
merged 4 commits into from Feb 21, 2019

Conversation

Projects
None yet
1 participant
@alexAubin
Copy link
Member

alexAubin commented Feb 5, 2019

Problem

See YunoHost/issues#703 and YunoHost/yunohost#291

It's easy to remove /version from yunohost-api, but the admin relies on it in several place. This problem was blocking for YunoHost/yunohost#291 ...

Solution

I tried to have an elegant solution through the moulinette but it was a complete technical mess so I gave up this. Instead, I just rely on the diagnosis route.

The version in the footer is updated after fetching the diagnosis (also used for the meltdown vulnerability check)

I also move the whole "initial checks" stuff to events.js realizing it's probably cleaner and relevant.

Status

Tested, should be working

In fact we do need this so that the footer gets the correct value eve…
…n if opening a new tab while already logged in

@alexAubin alexAubin added this to the 3.5.x milestone Feb 5, 2019

@alexAubin

This comment has been minimized.

Copy link
Member Author

alexAubin commented Feb 13, 2019

I can haz review ? :s

Basically the important changes are 28c788f and f0a4428

@alexAubin alexAubin merged commit 5625be5 into stretch-unstable Feb 21, 2019

@alexAubin alexAubin deleted the change-version-fetch-method branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment