Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apps infos in backup_info #236

Merged
merged 4 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@kay0u
Copy link
Contributor

commented Apr 2, 2019

Add information inside the backup_info page such as: Description, version and size.

Needs: YunoHost/yunohost#699

I don't know how to add the size of the "system" part. The function:

groupHooks: function(hooks) {
makes me confused.

@kay0u kay0u referenced this pull request Apr 2, 2019

Merged

Add size of apps in backup_info result #699

0 of 4 tasks complete

@alexAubin alexAubin added this to the 3.6.x milestone Apr 16, 2019

@alexAubin
Copy link
Member

left a comment

Quick review, LGTM though I'd like to run a quick test (and check this thing about system parts)

@alexAubin

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Sooo I ended up implementing a dirty hack to also compute the size of system parts (even the grouped ones) ...

This whole groupHooks thing really sounds like madness and bad design of the granularity of the system backup thing (I mean we literally have a whole independent hook just to backup the mysql password, and another one just to backup the current main domain, and so on ...) but anyway, let's live with it

@alexAubin

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Planning to merge soon

@alexAubin alexAubin merged commit ed57c01 into YunoHost:stretch-unstable May 13, 2019

@kay0u kay0u deleted the kay0u:add-apps-infos branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.