Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Convert ascii progress bars to bootstrap progress bar #244

Merged
merged 2 commits into from Jun 3, 2019

Conversation

Projects
None yet
1 participant
@alexAubin
Copy link
Member

commented May 15, 2019

The problem

ynh_script_progression is awesome, but the progress bar rendering in the webadmin is a bit funky because of the use of non-monospace font ... Especially the 'dot' which is small compared to the width of the #. But that's understood since that's designed for CLI anyway ;)

2019-05-15-214058_1366x768_scrot

Proposed solution

Change the display code to detect progress bars using a regex, and inject a bootstrap-based progress bar instead :

2019-05-15-213751_1366x768_scrot

Animated version (with YunoHost/yunohost#724 enabled)

ezgif-2-6b04a3cd9d3a

How to test

Pull the branch and try to install an app like Wordpress

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Soooo idk, proposing to merge in a few days

@alexAubin alexAubin added this to the 3.6.x milestone May 30, 2019

@alexAubin alexAubin merged commit 20617f6 into stretch-unstable Jun 3, 2019

@alexAubin alexAubin deleted the app-progress-bars branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.