Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minlength/maxlength on admin password form #245

Merged

Conversation

Projects
None yet
2 participants
@decentral1se

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

Bump 🦈 🦈 🦈

@alexAubin
Copy link
Member

left a comment

LGTM, not tested but looks like a small legit change !

Out of curiosity, what's the behavior if the password doesn't match the constrain ? (Too lazy to test sorry @.@)

@decentral1se

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

Out of curiosity, what's the behavior if the password doesn't match the constrain ? (Too lazy to test sorry @.@)

No worries! The behaviour is that the web UI reports a failure and then, at least for me, I could not see any log message to indicate it was about the password. I then ran the CLI postinstall (after doing a rm -rf yunohost) and saw the password length reported.

@alexAubin alexAubin added this to the 3.6.x milestone May 30, 2019

@alexAubin alexAubin merged commit 713dd27 into YunoHost:stretch-unstable Jun 3, 2019

@decentral1se decentral1se deleted the decentral1se:formfix/password-min-max branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.