Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config panel ynh arguments #251

Merged
merged 10 commits into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@Psycojoker
Copy link
Member

commented Jun 4, 2019

Matching PR for YunoHost/yunohost#734

@decentral1se
Copy link
Contributor

left a comment

Just some questions, looks cool.

@@ -430,6 +435,7 @@
if (args[k].type == 'boolean') {
args[k].inputType = 'checkbox';

console.log(args[k]);

This comment has been minimized.

Copy link
@decentral1se

decentral1se Jun 25, 2019

Contributor

Debugging only or?

This comment has been minimized.

Copy link
@Psycojoker

Psycojoker Jun 25, 2019

Author Member

Yes, PRs aren't finished yet

This comment has been minimized.

Copy link
@decentral1se

decentral1se Jun 25, 2019

Contributor

Ah right. You can add "WIP" to the title and Github will make this PR a "draft". I'll resolve comments. EDIT: I've just seen "work needed" label, ignore me :)

{{#choices}}<option value="{{value}}" {{#if selected}}selected{{/if}}>{{label}}</option>{{/choices}}
</select>
{{else if (eq inputType "checkbox")}}
<input type="{{inputType}}" id="{{name}}" name="{{name}}" class="form-control auto-width" value="{{default}}" placeholder="{{example}}" {{required}} {{{attributes}}}>

This comment has been minimized.

Copy link
@decentral1se

decentral1se Jun 25, 2019

Contributor

{{{ on attributes is correct or? Not familiar with this syntax.

This comment has been minimized.

Copy link
@Psycojoker

Psycojoker Jun 25, 2019

Author Member

Came from here from where the code is adapted from https://github.com/YunoHost/yunohost-admin/blob/stretch-unstable/src/views/app/app_install.ms#L68

Tbh I don't know either, I think it's simply the **kwargs of python in mustache templates.

@Psycojoker Psycojoker force-pushed the config-panel-ynh-arguments branch from 8242f34 to c5fde43 Jul 2, 2019

@alexAubin alexAubin merged commit 6109a1c into stretch-unstable Jul 2, 2019

@alexAubin alexAubin deleted the config-panel-ynh-arguments branch Jul 2, 2019

@alexAubin alexAubin added this to the 3.6.x milestone Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.