[fix] Support git ynh app with submodules #533 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Moul had made an answer about this pr. I need to take time to explore his proposal. |
|
The Moul answer is here https://dev.yunohost.org/issues/533#change-1803 |
|
I tried subtrees, it works without this change. But I suggest to merge this contribution to be able to support submodules too. |
Psycojoker
approved these changes
Nov 25, 2016
|
I'm calling for a small decision on this one. |
julienmalik
approved these changes
Nov 25, 2016
M5oul
approved these changes
Nov 25, 2016
opi
approved these changes
Nov 25, 2016
|
I have merged it (5 positive vote since 5 days) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use git submodule for assure the iso sources but yunohost doesn't support it with a non github url because the git clone is not recursive.
Since git 2.9 there is an option to force submodule to just download the last commit --shallow-submodules https://git-scm.com/docs/git-clone , but with the current yunohost (debian jessie) git is in version 2.1 so we should wait before adding this option.
This Merge Request is linked to the ticket https://dev.yunohost.org/issues/533