New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Bootprompt is back #363

Merged
merged 10 commits into from May 26, 2018

Conversation

Projects
None yet
4 participants
@zamentur
Contributor

zamentur commented Sep 1, 2017

Problem

User are a bit lost after installation of yunohost since the boot prompt has disappear in YunoHost 2.4.

Suggested solution

Display the boot prompt has before
yunoprompt
Note: I have remove uptime and Main domain

How to test

To test you need to put
bin/yunoprompt in /usr/bin/
data/other/yunoprompt.service in /etc/systemd/system/

chmod u+x /usr/bin/yunoprompt

After that run systemctl enable yunoprompt and restart a VM with a VNC console. You will see the new boot prompt.

PR Status

Opinion needed

Validation

  • Principle agreement 2/2 : Aleks, opi
  • Quick review 1/1 : opi
  • Simple test 0/1 :
  • Deep review1/1: Aleks
Show outdated Hide outdated bin/yunoprompt Outdated
Show outdated Hide outdated bin/yunoprompt Outdated
@Psycojoker

This comment has been minimized.

Show comment
Hide comment
@Psycojoker

Psycojoker Oct 6, 2017

Member

As someone tested this one?

Member

Psycojoker commented Oct 6, 2017

As someone tested this one?

@alexAubin alexAubin added this to the 2.7.x (fixes) or 2.8 milestone Oct 7, 2017

@alexAubin

This comment has been minimized.

Show comment
Hide comment
@alexAubin

alexAubin Oct 12, 2017

Member

I tested it in with ynh-dev / virtualbox but was unable to get the prompt to be displayed in the virtualbox screen... Despite the /etc/issue.net being filled correctly. Am I missing something ? Shouldn't it change the /etc/issue file instead ? (I don't know why there are two files and when exactly they are being used :/)

Member

alexAubin commented Oct 12, 2017

I tested it in with ynh-dev / virtualbox but was unable to get the prompt to be displayed in the virtualbox screen... Despite the /etc/issue.net being filled correctly. Am I missing something ? Shouldn't it change the /etc/issue file instead ? (I don't know why there are two files and when exactly they are being used :/)

@zamentur

This comment has been minimized.

Show comment
Hide comment
@zamentur

zamentur May 15, 2018

Contributor

/etc/issue display a message on the screen and /etc/issue.net display a message on SSH console. We could add some /etc/issue.net file but i think it's another PR.

On my ynh-dev instance it works like a charm ! May be you had forgotten to enable the service ?

new_test

Contributor

zamentur commented May 15, 2018

/etc/issue display a message on the screen and /etc/issue.net display a message on SSH console. We could add some /etc/issue.net file but i think it's another PR.

On my ynh-dev instance it works like a charm ! May be you had forgotten to enable the service ?

new_test

@zamentur zamentur removed the work needed label May 15, 2018

@zamentur

This comment has been minimized.

Show comment
Hide comment
@zamentur

zamentur May 15, 2018

Contributor

Exact /etc/issue.net is not needed (i just tested it)

Contributor

zamentur commented May 15, 2018

Exact /etc/issue.net is not needed (i just tested it)

@Psycojoker

This comment has been minimized.

Show comment
Hide comment
@Psycojoker

Psycojoker May 16, 2018

Member

I guess we can merge it then?

Member

Psycojoker commented May 16, 2018

I guess we can merge it then?

Show outdated Hide outdated bin/yunoprompt Outdated
Show outdated Hide outdated bin/yunoprompt Outdated
Show outdated Hide outdated bin/yunoprompt Outdated
${fingerprint[1]}
${fingerprint[2]}
${fingerprint[3]}
${fingerprint[4]}

This comment has been minimized.

@alexAubin

alexAubin May 17, 2018

Member

In fact there might not be exactly 4 fingerprints since that depends of which keys are generated, and therefore of sshd_config which we only manage on x86 ISO installations :P But that shouldnt prevent the script from working because it returns an empty string if the index is too large

@alexAubin

alexAubin May 17, 2018

Member

In fact there might not be exactly 4 fingerprints since that depends of which keys are generated, and therefore of sshd_config which we only manage on x86 ISO installations :P But that shouldnt prevent the script from working because it returns an empty string if the index is too large

@alexAubin

This comment has been minimized.

Show comment
Hide comment
@alexAubin

alexAubin May 17, 2018

Member

I propose an alternative logo because the current one ends up being a bit messy to read... That's not fantastic but that should be a bit more elegant / readable

capture du 2018-05-17 22-04-37

Member

alexAubin commented May 17, 2018

I propose an alternative logo because the current one ends up being a bit messy to read... That's not fantastic but that should be a bit more elegant / readable

capture du 2018-05-17 22-04-37

@zamentur

This comment has been minimized.

Show comment
Hide comment
@zamentur

zamentur May 20, 2018

Contributor

The new logo sounds good

Contributor

zamentur commented May 20, 2018

The new logo sounds good

@alexAubin

This comment has been minimized.

Show comment
Hide comment
@alexAubin

alexAubin May 20, 2018

Member

In fact we were wondering with Bram the other day on the chat :P

Maybe that one could be better : http://patorjk.com/software/taag/#p=display&f=Modular&t=Yuno%0AHost

Member

alexAubin commented May 20, 2018

In fact we were wondering with Bram the other day on the chat :P

Maybe that one could be better : http://patorjk.com/software/taag/#p=display&f=Modular&t=Yuno%0AHost

@zamentur

This comment has been minimized.

Show comment
Hide comment
@zamentur

zamentur May 20, 2018

Contributor

Quite too big, if we put it on a single line, i agree

Contributor

zamentur commented May 20, 2018

Quite too big, if we put it on a single line, i agree

@zamentur

This comment has been minimized.

Show comment
Hide comment
@zamentur

zamentur May 20, 2018

Contributor

Max 10 lines I think

Contributor

zamentur commented May 20, 2018

Max 10 lines I think

@alexAubin

This comment has been minimized.

Show comment
Hide comment
@alexAubin

alexAubin May 20, 2018

Member

So I removed the from_script thing and updated the logo

Looks like this now 😉

capture du 2018-05-21 00-58-33

Member

alexAubin commented May 20, 2018

So I removed the from_script thing and updated the logo

Looks like this now 😉

capture du 2018-05-21 00-58-33

@zamentur

This comment has been minimized.

Show comment
Hide comment
@zamentur

zamentur May 20, 2018

Contributor

Ok we merge like this or we try to find a solution for sha256 fingerprint ?

Contributor

zamentur commented May 20, 2018

Ok we merge like this or we try to find a solution for sha256 fingerprint ?

@alexAubin

This comment has been minimized.

Show comment
Hide comment
@alexAubin

alexAubin May 21, 2018

Member

Idk, imho we can merge like this and iterate later if needed, this PR is already like 7 months old 😅

Member

alexAubin commented May 21, 2018

Idk, imho we can merge like this and iterate later if needed, this PR is already like 7 months old 😅

@Psycojoker Psycojoker merged commit ebd5b33 into unstable May 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Psycojoker Psycojoker deleted the enh-boot-prompt branch May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment