New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 'dyndns update' should check the upstream dns record #519

Merged
merged 4 commits into from Oct 27, 2018

Conversation

Projects
None yet
3 participants
@irina11y
Contributor

irina11y commented Aug 27, 2018

@@ -252,6 +226,30 @@ def dyndns_update(dyn_host="dyndns.yunohost.org", domain=None, key=None,
'zone %s' % host,
]


old_ipv4 = check_output("dig @91.224.148.92 +short %s" % domain).strip()
old_ipv6 = check_output("dig @91.224.148.92 +short aaaa %s" % domain).strip()

This comment has been minimized.

@Psycojoker

Psycojoker Aug 27, 2018

Member

It looks like every YunoHost is going to make a request to a DNS server every 2min, isn't that a lot for those DNS server? I could be like ~3000 requests every 2min (if everyone has updated), I'm not sure it's good.

This comment has been minimized.

@Psycojoker

Psycojoker Sep 3, 2018

Member

After an IRC discussion that should be alright, we are hitting our own DNS servers.

This comment has been minimized.

@Psycojoker

Psycojoker Sep 3, 2018

Member

I'm still wondering if we shouldn't switch a DNS resolution here, this IP is own by tetaneutral and if we lose it for wathever reason all the dyndns domains are going to be in a shitty situation while if we bind that to the domain we own, it would be way more safe.

This comment has been minimized.

@alexAubin

alexAubin added some commits Oct 24, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Fixed a few things, proposing to merge soon

@alexAubin alexAubin added the important label Oct 24, 2018

@alexAubin alexAubin merged commit 1a05cd8 into YunoHost:stretch-unstable Oct 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment