New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ynh_delete_file_checksum #524

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
5 participants
@maniackcrudelis
Contributor

maniackcrudelis commented Aug 28, 2018

The problem

During a change_url script, the checksum of the nginx conf file has to be removed.

Solution

Provide a simple helper to remove a checksum corresponding to a file.

PR Status

Ready to be reviewed.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@JimboJoe

This comment has been minimized.

Member

JimboJoe commented Aug 28, 2018

How will that play with apps that already use this helper with positional arguments (e.g. wallabag2)?

@maniackcrudelis

This comment has been minimized.

Contributor

maniackcrudelis commented Aug 28, 2018

Any application which is not using getopts arguments will trig the "Legacy mode" https://github.com/YunoHost/yunohost/pull/520/files#diff-a1f538c2eae234f6ba78e0bed0ae54dbR164

@JimboJoe

Looks very good to me (not tested the getopts version, though)

@maniackcrudelis

This comment has been minimized.

Contributor

maniackcrudelis commented Aug 28, 2018

If you're brave enough, could be nice to try quickly this helper with wallabag2 ;)
My VM is already in use with YunoRunner.

@JimboJoe

This comment has been minimized.

Member

JimboJoe commented Aug 29, 2018

I was brave enough, and it's working in legacy mode and in "standard" mode after changing the call syntax 👍

@maniackcrudelis

This comment has been minimized.

Contributor

maniackcrudelis commented Aug 29, 2018

Wonderful, thanks for your try

@Psycojoker Psycojoker merged commit cedaaa9 into stretch-unstable Oct 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Psycojoker Psycojoker deleted the add_ynh_delete_file_checksum branch Oct 3, 2018

@alexAubin alexAubin added this to the 3.3.x milestone Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment