New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yunohost.multimedia helpers #525

Open
wants to merge 6 commits into
base: stretch-unstable
from

Conversation

Projects
None yet
5 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Aug 28, 2018

Add helpers to handle yunohost.multimedia

PR Status

Ready to be reviewed.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@Josue-T

This comment has been minimized.

Copy link
Contributor

Josue-T commented Aug 29, 2018

Hello,

Is it not better to implement this directly in the core ?

@zamentur zamentur changed the base branch from stretch-unstable to stretch-testing Oct 4, 2018

@zamentur zamentur changed the base branch from stretch-testing to stretch-unstable Oct 4, 2018

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Dec 18, 2018

I just noticed the flag work needed on this PR.
Why that ?
Those helpers are already used in many apps, what else needs to be done ?

@Psycojoker

This comment has been minimized.

Copy link
Member

Psycojoker commented Jan 3, 2019

@zamentur there is a question for you ^ (also please justify when you add this tag, it's not the first time I see you doing this without any explanation and that can be quite aggressive)

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Jan 3, 2019

Well, looks like explanation aren't needed... So I remove this flag (without any explanation...)

maniackcrudelis added some commits Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment