New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCSP Stapling #533

Merged
merged 12 commits into from Oct 27, 2018

Conversation

@frju365
Member

frju365 commented Aug 31, 2018

The problem

  • Every time, the browser needs to send a request to LE to check if the SSL Cert is not revoked.

Solution

  • Add OCSP Stapling

PR Status

Not tested.
Review required.

How to test

Install Yunohost + nginx

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

frju365 added some commits Aug 31, 2018

@@ -54,6 +54,14 @@ do_pre_regen() {
[[ $main_domain != $domain ]] \
&& touch "${domain_conf_dir}/yunohost_local.conf" \
|| cp yunohost_local.conf "${domain_conf_dir}/yunohost_local.conf"

domain_ca_type=$(yunohost domain cert-status ${domain} | grep CA_type | tr -d " ")

This comment has been minimized.

@Psycojoker

Psycojoker Sep 3, 2018

Member

Now that we have jq provided with YunoHost, you can do way more cleaner and strong code like this:

root@yunorunner:/home/vagrant# yunohost domain cert-status yunorunner.local --json | jq '.certificates."yunorunner.local".CA_type'
"Self-signed"

This comment has been minimized.

@frju365

frju365 Sep 3, 2018

Member

mh ok :)

@frju365

This comment has been minimized.

Member

frju365 commented Sep 3, 2018

Don't know, if it will work as I used just a vm to test condition and not a real one with a signed certificate.

frju365 added some commits Sep 3, 2018

@frju365

This comment has been minimized.

Member

frju365 commented Oct 6, 2018

Ma PR est correcte ?

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 6, 2018

Est-ce que tu l'as testée ? :/

frju365 and others added some commits Oct 7, 2018

@alexAubin

Partially tested, should be ~okay now

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Proposing to merge in a few days

@alexAubin alexAubin merged commit fa66a7b into YunoHost:stretch-unstable Oct 27, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@frju365 frju365 deleted the frju365:patch-3 branch Oct 27, 2018

@frju365 frju365 added this to Done in Yunohost Security Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment