[enh] Improve upnp support

[zamentur]

The problem

https://forum.yunohost.org/t/work-around-router-upnp-shortcomming-implementations-netgear-cbvg834g/5730

Solution

teajay-fr suggest to increase discover time and listen on 1900 to support some router that doesn't respond to discover query

Note: i don't know if it's solution increase the postinstall time ?

PR Status

Need Feedback, i don't know if it's a good idea

How to test

...

Validation

• Principle agreement 0/2 :
• Quick review 0/1 :
• Simple test 0/1 :
• Deep review 0/1 :

[Psycojoker]

Has anyone tested that? I don't have this kind of configuration here.

[alexAubin]

I don't have any way to test that either, or any experience with Upnp :/ ...

We could blindly merge this though, that sounds relatively safe ? Idk...

[teajay-fr]

This probably won't help in assessing the usefullness of this approach since I came up with it :)
I can just testify that I got my netgear CBVG834G to accept the UPNP updates using this trick.
For routers that correctly implement the UPNP protocol, this should not have any drawback.

[zamentur]

I suggest we add this in a testing and see if upnp still works

[kay0u]

Hi, I had this error:

yunohost firewall allow --no-upnp TCP 8080

2018-12-22 16:06:05,411: DEBUG - Traceback (most recent call last):
2018-12-22 16:06:05,411: DEBUG -   File "/usr/bin/yunohost", line 213, in <module>
2018-12-22 16:06:05,412: DEBUG -     timeout=opts.timeout,
2018-12-22 16:06:05,412: DEBUG -   File "/usr/lib/python2.7/dist-packages/moulinette/__init__.py", line 136, in cli
2018-12-22 16:06:05,412: DEBUG -     moulinette.run(args, output_as=output_as, password=password, timeout=timeout)
2018-12-22 16:06:05,412: DEBUG -   File "/usr/lib/python2.7/dist-packages/moulinette/interfaces/cli.py", line 425, in run
2018-12-22 16:06:05,412: DEBUG -     ret = self.actionsmap.process(args, timeout=timeout)
2018-12-22 16:06:05,412: DEBUG -   File "/usr/lib/python2.7/dist-packages/moulinette/actionsmap.py", line 523, in process
2018-12-22 16:06:05,413: DEBUG -     return func(**arguments)
2018-12-22 16:06:05,413: DEBUG -   File "/usr/lib/moulinette/yunohost/firewall.py", line 94, in firewall_allow
2018-12-22 16:06:05,413: DEBUG -     return firewall_reload()
2018-12-22 16:06:05,413: DEBUG -   File "/usr/lib/moulinette/yunohost/firewall.py", line 209, in firewall_reload
2018-12-22 16:06:05,413: DEBUG -     upnp = firewall_upnp()['enabled'] if not skip_upnp else False
2018-12-22 16:06:05,414: DEBUG -   File "/usr/lib/moulinette/yunohost/firewall.py", line 346, in firewall_upnp
2018-12-22 16:06:05,414: DEBUG -     upnpc.localport = 1900
2018-12-22 16:06:05,414: DEBUG - AttributeError: 'miniupnpc.UPnP' object has no attribute 'localport'

I'm not sure what I have done, but now this is working... If I found something on this error, i'll come back to you

[alexAubin]

Okay guys, this is still broken (encountered the error on a fresh install in 3.4) so I reverted 640bc49 for now ...