New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Silent output/warning but display errors #545

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
4 participants
@zamentur
Contributor

zamentur commented Sep 19, 2018

The problem

When we use ynh_setup_source there is a strange noisy warning like this. This noise is displayed to the user...

2018-09-19 16:11:29 URL:https://github-production-release-asset-2e65be.s3.amazonaws.com/271714/6b136718-52da-11e7-93f3-2b4ee2eccece?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20180919%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20180919T141124Z&X-Amz-Expires=300&X-Amz-Signature=15c6db1dc3ca633a3e4ba8e903500976d38a5100dcd1ea022deaa72cd15b5c34&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dwkhtmltox-0.12.4_linux-generic-amd64.tar.xz&response-content-type=application%2Foctet-stream [14541904/14541904] -> "app.tar.xz" [1]

Solution

Display only error but not output. wget has no option for that, so we need to make like in this pr or replace wget with curl.

PR Status

Ready, tested by copy/pasta inside a vm

How to test

Install an app, you should not see a warning about download success

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@zamentur zamentur added the helper label Sep 19, 2018

@zamentur

This comment has been minimized.

Contributor

zamentur commented Sep 19, 2018

@maniackcrudelis may be continuous integration tests use this strange warning ?

@alexAubin

LGTM

@zamentur zamentur requested a review from maniackcrudelis Oct 1, 2018

@Psycojoker Psycojoker merged commit f6780ae into stretch-unstable Oct 3, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@Psycojoker Psycojoker deleted the fix-noisy-wget branch Oct 3, 2018

@Psycojoker

This comment has been minimized.

Member

Psycojoker commented Oct 3, 2018

Merged a bit fast, should we ALSO display this log on debug? To be able... to debug.

@alexAubin alexAubin added this to the 3.3.x milestone Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment