New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a separate ini file for php pools #548

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Oct 1, 2018

The problem

Have a look to YunoHost-Apps/nextcloud_ynh#138 for more information.

Solution

Do not use separate ini file anymore.

PR Status

Ready to be reviewed.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 : Josué
  • Deep review 0/1 :
Show resolved Hide resolved data/helpers.d/backend
@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Oct 24, 2018

Bumpitybump, any update on this ? Should we go for Maniack's solution to only have a warning instead ?

@zamentur
Copy link
Contributor

zamentur left a comment

LGTM

@alexAubin alexAubin added this to the 3.4.x milestone Dec 1, 2018

@alexAubin alexAubin merged commit 41c1a9c into stretch-unstable Dec 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the do_not_use_phpini branch Dec 1, 2018

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Jan 24, 2019

Should we go for Maniack's solution to only have a warning instead ?

Yep, we should have done that instead...
That's actually a mistake, because any application with such a ini file will fail to be backup because this file is missing...
Also, there was an error in my redirection, &>2 instead of >&2. The warning isn't print on stderr but stdout... So I've missed it...

maniackcrudelis added a commit that referenced this pull request Jan 24, 2019

@maniackcrudelis maniackcrudelis referenced this pull request Jan 24, 2019

Merged

Fix #548 #627

0 of 4 tasks complete

alexAubin added a commit that referenced this pull request Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment