Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[enh] allows to have several domains/path per app #549
Some apps wants to be able to have several domains/path because they ship several components.
Allows up to 9 domains per applications. using "domain2/path2" "domain3/path3" ... notation for keys.
I could have made it generic and allows infinite additional domains but that would have made the code way more complex than needed and the case where an app wants 2 domains is already super rare, I can't think of someone wanting more than 3-4 so that should be a good enough marging.
Worst case those people will contact us.
Test and working.
BUT, there might be other places in the code where this modification need to be done but I don't know where.
How to test
Edit the config of an app, add "domain2/path2" kind of keys, then do "yunohost app map" and "yunohost app ssowatconf" and see the result.
So, @julienmalik tested it, said it was nearly perfect, it just also needs to handle labels, this raise unexpected new work, todo:
@julienmalik args that since this doesn't break anything we can still have the strategy to merge it then add needed things one by one which would make things easier, I still think we need TODO element 1 (label[2-9]) and explore 4.
Working on the code I realize that:
There are probably other things hiding around.