New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add a proper conf for LDAP (Issue 1218) #554

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@frju365
Member

frju365 commented Oct 7, 2018

The problem

Solution

  • Complete conf

PR Status

Work finished. Tested in production. As it's not really setup configuration.

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

frju365 added some commits Oct 7, 2018

@frju365 frju365 changed the title from Try to fix https://github.com/YunoHost/issues/issues/1218 with the fix provided in the issue to [fix] Add a proper conf for LDAP (fix 1218) Oct 7, 2018

@frju365 frju365 changed the title from [fix] Add a proper conf for LDAP (fix 1218) to [fix] Add a proper conf for LDAP (Issue 1218) Oct 7, 2018

@zamentur

LGTM untested

@alexAubin

Tested and seems to work okay, yolomerging 👍

@alexAubin alexAubin merged commit 556f33f into YunoHost:stretch-unstable Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexAubin alexAubin added this to the 3.3.x milestone Oct 24, 2018

@frju365 frju365 deleted the frju365:patch-8 branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment