New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Host header to YunoHost API #560

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@randomstuff
Contributor

randomstuff commented Oct 15, 2018

This is useful to validate Origin/Referer headers in order to prevent CSRF.

The problem

We might want to validate Referer/Origin headers to prevent CSRF but the Host header passed to the application is localhost:$port instead of the original one.

Solution

Let nginx pass the original Host header.

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Pass Host header to YunoHost API
This is useful to validate Origin/Referer headers in order to prevent
CSRF.
@frju365

LGTM

@alexAubin alexAubin added this to the 3.3.x milestone Oct 24, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Yolomergin'

@alexAubin alexAubin merged commit 374369a into YunoHost:master Oct 24, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

(Uh dunno why the target branch was master, but anyway I cherry-picked this to stretch-unstable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment