New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sorting lambda function when sorting the backups list #562

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@jershon
Contributor

jershon commented Oct 16, 2018

The problem

Issue YunoHost/issues#1001

Solution

When sorting the list of backups, instead of sorting them by name (default) use a lambda function that sort them by creation date of the file.

PR Status

I'm sorry, I was not able to test it... I can't have the testing VM to work on my computer :(

How to test

Create some backups by giving them different names. See how the backups are sorted.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@jershon jershon referenced this pull request Oct 16, 2018

Closed

Sort backups by date #1001

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Yolomergin, thanks !

@alexAubin alexAubin merged commit a16b6f0 into YunoHost:stretch-unstable Oct 24, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@alexAubin alexAubin added this to the 3.3.x milestone Oct 24, 2018

@jershon jershon deleted the jershon:enh-1001-sort-backups-by-date branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment