New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Allow - between two name #565

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@frju365
Member

frju365 commented Oct 20, 2018

The problem

Solution

  • change regex to allow "-" in lastname.

PR Status

Tested. Work finished.
Micro-decision.

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.2.x milestone Oct 24, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Yolomergin

@alexAubin alexAubin merged commit debec7b into YunoHost:stretch-unstable Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexAubin alexAubin modified the milestones: 3.2.x, 3.3.x Oct 24, 2018

@frju365 frju365 deleted the frju365:patch-14 branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment