New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Use more blocks for dd in ynh_string_random #569

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Contributor

maniackcrudelis commented Nov 4, 2018

The problem

200 are not enough if you try to generate a 64 characters string.

Solution

Use 1000 blocks instead

PR Status

Ready to be reviewed

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
[enh] Use more blocks for dd in ynh_string_random
200 are not enough if you try to generate a 64 characters string.

@alexAubin alexAubin added this to the 3.3.x milestone Nov 4, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Nov 4, 2018

Merging as microdecision

@alexAubin alexAubin merged commit a830cdf into stretch-unstable Nov 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the more_blocks_ynh_string_random branch Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment