New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] app_removeaccess call set.add #573

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@airwoodix
Contributor

airwoodix commented Nov 13, 2018

The problem

In yunohost/app.py, app_removeaccess calls allowed_users.append which doesn't exist for the set allowed_users.

Solution

Call allowed_users.add.

PR Status

Trivial change. Tested in production. Ready to be reviewed.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin

This comment has been minimized.

Member

alexAubin commented Nov 13, 2018

Many thanks !

@alexAubin alexAubin merged commit 047947d into YunoHost:stretch-unstable Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexAubin alexAubin added this to the 3.3.x milestone Nov 13, 2018

@airwoodix airwoodix deleted the airwoodix:fix-app-removeaccess-set-add branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment