New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Allow to not fail on backup and restore for some files #576

Merged
merged 2 commits into from Dec 9, 2018

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Nov 20, 2018

The problem

Following #558, this PR allow to specify that, for a file, the backup process can continue if the file is missing.
The same argument has to be added to the restore command to ignore it as well.

Solution

Simply ignore the file during the backup and the restore process, and do not fail.

PR Status

Tested on a VM.
Can be reviewed.

How to test

Add the argument in the backup and restore script for a file.
Replace the helper, and remove a file used during the backup.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@zamentur
Copy link
Contributor

zamentur left a comment

LGTM untested

@alexAubin alexAubin added this to the 3.4.x milestone Dec 1, 2018

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Dec 1, 2018

So uh, not sure what to do with the conflict with the fail2ban thing

@alexAubin alexAubin merged commit 0881875 into stretch-unstable Dec 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the ignore_file_backup branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment