New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 On #580

Merged
merged 2 commits into from Nov 27, 2018

Conversation

5 participants
@liberodark
Copy link
Contributor

liberodark commented Nov 22, 2018

for better security

The problem

...

Solution

...

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 : Josué
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
HTTP2 On
for better security
@liberodark

This comment has been minimized.

Copy link
Contributor Author

liberodark commented Nov 22, 2018

Informations :
#578 (comment)

@frju365
Copy link
Member

frju365 left a comment

LGTM, ok if tested.
(~~ the same PR as #448)

@liberodark

This comment has been minimized.

Copy link
Contributor Author

liberodark commented Nov 22, 2018

Thx @frju365

@alexAubin alexAubin added this to the 3.4.x milestone Nov 22, 2018

@Josue-T

This comment has been minimized.

Copy link
Contributor

Josue-T commented Nov 22, 2018

I'm for but we need to do some test with the CI in the testing.

@frju365

This comment has been minimized.

Copy link
Member

frju365 commented Nov 22, 2018

well, yes. That the reason it will be merged on stretch-unstable ?

@frju365 frju365 added this to In progress in Yunohost Security Nov 22, 2018

@zamentur

This comment has been minimized.

Copy link
Contributor

zamentur commented Nov 22, 2018

Note: HTTP2 has already been tested but some apps installation was broken with it. We need to find a solution for those apps.

@frju365

This comment has been minimized.

Copy link
Member

frju365 commented Nov 22, 2018

@zamentur : there was already a fix.... Problem was CURL and a PR has already been done :// #547 or did I miss something ?

@frju365

This comment has been minimized.

Copy link
Member

frju365 commented Nov 22, 2018

I don't understand what work is needed... :/

@alexAubin alexAubin removed the work needed label Nov 22, 2018

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Nov 22, 2018

There's no work needed, we just need to merge this (after we release 3.3 stable) and then wait for CI result from testing (assuming we still have a testing CI)

@Josue-T

This comment has been minimized.

Copy link
Contributor

Josue-T commented Nov 22, 2018

I purpose after the 3.3 stable is released, directly we can merge this and make a testing with only this feature.

@alexAubin alexAubin merged commit 76121ea into YunoHost:stretch-unstable Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Yunohost Security automation moved this from In progress to Done Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment