New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Add post_cert_update hook each time certificate is updated #586

Merged
merged 1 commit into from Dec 9, 2018

Conversation

Projects
None yet
3 participants
@alexAubin
Copy link
Member

alexAubin commented Nov 27, 2018

The problem

Some apps need to reload stuff each time the certificate changes, e.g. YunoHost-Apps/mumbleserver_ynh#23

Solution

Add a post_cert_update hook, called each time a different certificate is enabled (cert-install, cert-renew, and also self-signed cert reinstall or initialization)

PR Status

Not tested /o\

How to test

Try to use cert-install, cert-renew, ... check that the hook is called correctly

Validation

  • Principle agreement 0/2 : Josué
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@Josue-T
Copy link
Contributor

Josue-T left a comment

Had the same Idea to do that.

Also useful if we use Dane/TLSA

@zamentur
Copy link
Contributor

zamentur left a comment

LGTM

@zamentur zamentur added test needed and removed opinion needed labels Nov 30, 2018

@alexAubin alexAubin added this to the 3.4.x milestone Dec 3, 2018

@alexAubin alexAubin changed the title Add post_cert_update hook each time certificate is updated [enh] Add post_cert_update hook each time certificate is updated Dec 9, 2018

@alexAubin alexAubin merged commit fa5a226 into stretch-unstable Dec 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the hook-for-cert-renew branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment