New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return instead of break, otherwise warning is shown #593

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

alexAubin commented Dec 3, 2018

The problem

In ynh_wait_dpkg_free, there's a break if the lock is free. But right after the function, a warning is displayed (in all cases) saying the lock ain't free.

Solution

Use return because we don't wanna show a warning if the lock is free

PR Status

Microdecision / waiting for confirmation from @maniackcrudelis ;)

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin requested a review from maniackcrudelis Dec 3, 2018

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Dec 3, 2018

Indeed !

@maniackcrudelis maniackcrudelis merged commit 5338319 into stretch-unstable Dec 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@maniackcrudelis maniackcrudelis deleted the fix-wait-dpkg-free branch Dec 3, 2018

@alexAubin alexAubin added this to the 3.4.x milestone Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment