New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Repair tests #595

Merged
merged 7 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@Josue-T
Copy link
Contributor

Josue-T commented Dec 7, 2018

The problem

Many tests are broken

Solution

Fix it

Note that a fix is solved in moulinette in #185

PR Status

All test should be fixed

How to test

In the moulinette repos, use the branch fix_ldap_authenticator.

run ./ynh-dev test yunohost

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@Josue-T Josue-T requested review from Psycojoker , zamentur and alexAubin Dec 7, 2018

@Josue-T Josue-T force-pushed the fix_test branch from f939035 to 03b1a28 Dec 7, 2018

@alexAubin
Copy link
Member

alexAubin left a comment

That fixes quite a lot of things, thanks !

I still have a few tests failing, namely :

ERROR at teardown of test_backup_binds_are_readonly
>       assert tmp_backup_directory_is_empty()
E       assert False
E        +  where False = tmp_backup_directory_is_empty()

and

FAILURE : test_backup_binds_are_readonly
    def _organize_files(self):

        [...]

>       os.link(src, dest)
E       OSError: [Errno 18] Invalid cross-device link

Did you get those also ?

(I'm a bit lazy to dig deeper tho @.@ It's okay for me if we merge as is)

@Josue-T

This comment has been minimized.

Copy link
Contributor Author

Josue-T commented Dec 10, 2018

I think I don't have this error...

Remove hack for authenticator
It's solved in the moulinette with #185

@alexAubin alexAubin changed the title Fix test [fix] Repair tests Dec 12, 2018

@alexAubin alexAubin merged commit 0d83d35 into stretch-unstable Dec 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix_test branch Dec 12, 2018

@alexAubin alexAubin referenced this pull request Dec 20, 2018

Closed

Tests are broken @.@ #1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment