New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Ask confirmation before installing low-quality, experimental or third party apps #598

Merged
merged 5 commits into from Dec 15, 2018

Conversation

Projects
None yet
5 participants
@alexAubin
Copy link
Member

alexAubin commented Dec 11, 2018

The problem

Similar to YunoHost/yunohost-admin#218 : currently there is no warning shown when installing experimental or low quality apps. We should add some to discourage users installing apps likely to break their system ...

Solution

  • Ask for confirmation when installing low quality, broken/experimental, and third party apps
    • A "good quality" app is defined as working + level >= 3
    • A "low-quality app is defined as working + level = 1 or 2
    • A third-party app is when you install from an URL or local folder
    • A broken / experimental app is all other apps
  • --force can be used to not ask confirmation

PR Status

Tested and ready for feedback / discussions

How to test

Try to install an app with level 1~2, or level 0 / notworking / inprogress, from local folder and from explicit URL

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@zamentur
Copy link
Contributor

zamentur left a comment

LGTM

Show resolved Hide resolved locales/en.json Outdated
Show resolved Hide resolved locales/en.json Outdated
Show resolved Hide resolved locales/en.json Outdated
Update locales/en.json
Co-Authored-By: alexAubin <alex.aubin@mailoo.org>
Show resolved Hide resolved src/yunohost/app.py Outdated
Update locales/en.json
Co-Authored-By: alexAubin <alex.aubin@mailoo.org>

Psycojoker and others added some commits Dec 14, 2018

Update locales/en.json
Co-Authored-By: alexAubin <alex.aubin@mailoo.org>
Update src/yunohost/app.py
Co-Authored-By: alexAubin <alex.aubin@mailoo.org>
@Psycojoker
Copy link
Member

Psycojoker left a comment

LGTM, it's a VERY welcome change

@alexAubin alexAubin merged commit 174cbcb into stretch-unstable Dec 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the confirm-when-asking-bad-quality-apps branch Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment