Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[enh] Ask confirmation before installing low-quality, experimental or third party apps #598
Conversation
alexAubin
added
small decision
opinion needed
labels
Dec 11, 2018
alexAubin
added this to the 3.4.x milestone
Dec 11, 2018
Josue-T
approved these changes
Dec 11, 2018
frju365
approved these changes
Dec 12, 2018
alexAubin
added
the
ready to merge
label
Dec 12, 2018
Psycojoker
reviewed
Dec 14, 2018
locales/en.json Outdated
Psycojoker
reviewed
Dec 14, 2018
locales/en.json Outdated
Psycojoker
reviewed
Dec 14, 2018
locales/en.json Outdated
Psycojoker
reviewed
Dec 14, 2018
src/yunohost/app.py Outdated
Psycojoker
and others
added some commits
Dec 14, 2018
alexAubin
merged commit 174cbcb
into
stretch-unstable
Dec 15, 2018
alexAubin
deleted the
confirm-when-asking-bad-quality-apps
branch
Dec 15, 2018
alexAubin
referenced this pull request
Dec 19, 2018
Closed
Ask for confirmation when users want to install an app with questionnable quality #1235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexAubin commentedDec 11, 2018
The problem
Similar to YunoHost/yunohost-admin#218 : currently there is no warning shown when installing experimental or low quality apps. We should add some to discourage users installing apps likely to break their system ...
Solution
--forcecan be used to not ask confirmationPR Status
Tested and ready for feedback / discussions
How to test
Try to install an app with level 1~2, or level 0 / notworking / inprogress, from local folder and from explicit URL
Validation