New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] DEBUG-level messages not appearing in actions performed via the API #603

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

alexAubin commented Dec 19, 2018

The problem

c.f. YunoHost/issues#1251 : this is annoying as fuck that people show logs from failed app install without the DEBUG-level messages, which defeats the purpose of log feature from 3.2 x_x ...

Solution

Fix the loggers/handlers log level such that it's consistent with what was expected ...

PR Status

Tested and working

How to test

Launch an app install that will fail (or any action that shall add DEBUG stuff in the logs) and check the produced logs in /var/log/yunohost/categories/operations with and without this.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@zamentur
Copy link
Contributor

zamentur left a comment

LGTM

@alexAubin

This comment has been minimized.

Copy link
Member Author

alexAubin commented Dec 20, 2018

Yolomerging to have this in 3.4.0 testing

@alexAubin alexAubin merged commit ea77a8c into stretch-unstable Dec 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix-admin-logging-level branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment