New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #607

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@Josue-T
Copy link
Contributor

Josue-T commented Dec 28, 2018

The problem

The tests fail a new time 馃憥

Solution

Fix the errors. Thanks @alexAubin to help me to find the second bug

PR Status

All errors fixed.

How to test

launch ./ynh-dev test yunohost

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@Josue-T Josue-T requested review from Psycojoker , zamentur and alexAubin Dec 28, 2018

@Josue-T Josue-T force-pushed the fix_tests branch from 431861c to 4282d7e Dec 30, 2018

@alexAubin alexAubin added this to the 3.4.x milestone Jan 7, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 7, 2019

Yolomergin' as a microdecision

@alexAubin alexAubin merged commit 70aeb3e into stretch-unstable Jan 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix_tests branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment