New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues with bootprompt #609

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@alexAubin
Copy link
Member

alexAubin commented Jan 7, 2019

The problem

Currently there are several issues with the bootprompt, namely :

  • the IP field being empty (YunoHost/issues#1248)
  • some \n being displayed as literal \n (also mentionned in YunoHost/issues#1248)
  • after postinstall being successful, the bootprompt doesn't give back a working terminal hence users end up being stucked and have to reboot to get a working terminal (can't find the corresponding ticket for this issue)

Solution

I reworked and tweaked a few things :

  • fetch the ip after a sleep 5, which gives better changes that the network stack will be up
  • add a message similar introducing the postinstall and other things in a similar way to what's done after the install script
  • use chvt 1 to switch to a fresh tty after postinstall is done.

PR Status

Tested, ready for rewiews

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.4.x milestone Jan 7, 2019

@Psycojoker
Copy link
Member

Psycojoker left a comment

LGTM, took so time to read it carefully.

'Finalizing your setup' and 'Getting to know YunoHost'. It is available at
the following URL : https://yunohost.org/admindoc
===============================================================================
EOF

This comment has been minimized.

@zamentur

zamentur Jan 7, 2019

Contributor

Isn't it too long to be displayed on screen ?

This comment has been minimized.

@zamentur

zamentur Jan 7, 2019

Contributor

We could make a smaller logo on 3 lines to get more lines to explain.

This comment has been minimized.

@alexAubin

alexAubin Jan 7, 2019

Member

Idk, tested it in a virtualbox with the default "small" screen and it looked fine

This comment has been minimized.

@zamentur

zamentur Jan 7, 2019

Contributor

ok cool

@zamentur
Copy link
Contributor

zamentur left a comment

Have you tested it on a Virtualbox, I believe the screen height is too small to display all this information correctly ?

@zamentur
Copy link
Contributor

zamentur left a comment

LGTM

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 7, 2019

Well in term of height, yes : on the small default virtualbox screen, the yunohost logo is truncated. But imho that's not so much a big deal...

@Psycojoker Psycojoker merged commit bafeb28 into stretch-unstable Jan 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Psycojoker Psycojoker deleted the fix-bootprompt branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment