New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] propagate --no-checks cert-install option to renew crontab #610

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@Psycojoker
Copy link
Member

Psycojoker commented Jan 7, 2019

The problem

Sometime, user needs to uses the option --no-checks while installing new LE certificates because of their configuration, but this option is not put inside the crontab file thus the renew will never work and they'll either have to modify the cronfile by hand and do a renew by hand with --no-checks.

Should we propagate that to the "renew" command to?

Solution

Add --no-checks inside the cronfile if it's used in the command line.

PR Status

Done but untested (I don't have the setup for that :().

How to test

Have a instance where you can test this PR and run "cert-install" with "--no-checks" and check the cronfile.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin
Copy link
Member

alexAubin left a comment

Not tested but LGTM

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 15, 2019

Yolomerging so that Bram can test using unstable packages

@alexAubin alexAubin merged commit 6f89ce0 into stretch-unstable Jan 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin added this to the 3.4.x milestone Jan 15, 2019

@Psycojoker

This comment has been minimized.

Copy link
Member

Psycojoker commented Jan 15, 2019

Seems to be working as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment