New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Propagate HTTP2, more_set_headers and ecdh_curve changes to webadmin #618

Merged
merged 2 commits into from Jan 26, 2019

Conversation

Projects
None yet
3 participants
@frju365
Copy link
Member

frju365 commented Jan 18, 2019

The problem

  • We did the configuration with normal conf, but not admin

Solution

~~

PR Status

Need test. Tested.

How to test

Install Yunohost, apply conf

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

frju365 and others added some commits Jan 18, 2019

@alexAubin
Copy link
Member

alexAubin left a comment

Not tested but LGTM

@alexAubin alexAubin changed the title Admin conf improvement [fix] Propagate HTTP2, more_set_headers and ecdh_curve changes to webadmin Jan 18, 2019

@alexAubin alexAubin added this to the 3.4.x milestone Jan 18, 2019

@frju365

This comment has been minimized.

Copy link
Member Author

frju365 commented Jan 19, 2019

I've some strange thing when I test my server... every server has 2(!) SSL certificate, one is set as Yunohost.org (so, invalid) and the other is valid (from the nginx conf). Perhaps the ssl cert of admin_conf makes a conflict with the valid certificate. Did you have already this issue ?

For instance, don't merge, I wanted seriously to solve this problem.

@frju365

This comment has been minimized.

Copy link
Member Author

frju365 commented Jan 19, 2019

Well ok for merging. Let's talk about this issue in another issue.

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 19, 2019

Well, if this PR causes a bug, we shouldn't merge the PR until we understand the bug ...

So is there a bug, or not ?

@alexAubin alexAubin merged commit 951d60c into YunoHost:stretch-unstable Jan 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment