New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve protection against indexation from the robots. #622

Merged
merged 3 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@frju365
Copy link
Member

frju365 commented Jan 21, 2019

The problem

  • $http_user_agent ne permet pas bloquer totalement tout, et sûrement ne bloque pas tous les robot.

Solution

  • Ajouter une directive plus générale permettant de bloquer l'ensemble des contenu
  • Code plus propre qu'une fonction nginx
  • Évite de lister l'ensemble des User-Agent des robots d'indexation (ce qui est possible si c'est nécessaire)

PR Status

Tested, but need test (I don't know how to test the effect of the header)

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

Sources (because it's needed) :

frju365 added some commits Jan 21, 2019

@frju365 frju365 changed the title Update yunohost_admin.conf Improve protection against indexation from the robots. Jan 21, 2019

@frju365

This comment has been minimized.

Copy link
Member Author

frju365 commented Jan 26, 2019

I don't know why it's the second test which had problem.

@alexAubin @Psycojoker : Do I need to add more informations about the feature ?

@alexAubin
Copy link
Member

alexAubin left a comment

LGTM though that would be nice to have a better understanding of the implications ...

@alexAubin alexAubin added this to the 3.5.x milestone Feb 15, 2019

@alexAubin alexAubin merged commit 8f50bde into YunoHost:stretch-unstable Feb 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@frju365 frju365 deleted the ABLD:frju365-patch2 branch Feb 19, 2019

@frju365 frju365 restored the ABLD:frju365-patch2 branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment