New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] add systemd logs #624

Merged
merged 8 commits into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@kay0u
Copy link
Contributor

kay0u commented Jan 23, 2019

The problem

Some apps don't provide log files.

Solution

I have added the possibility to use systemd log (with journalctl)

PR Status

I either have to create a migration file to update the file /etc/yunohost/services.yml or check if log_type is defined, and if not, I'm considering that the log is a file (as old method)

How to test

Old method:

  • yunohost service log service_name --log /var/log/service_name/service_name.log
  • yunohost service log service_name --log /var/log/service_name/service_name.log /var/log/service_name/service_name2.log

New method:

  1. The old one is still compatible:
  • yunohost service log service_name --log /var/log/service_name/service_name.log
  • yunohost service log service_name --log /var/log/service_name/service_name.log /var/log/service_name/service_name2.log
  1. The new:
  • for a file: yunohost service log service_name --log /var/log/service_name/service_name.log --log_type file
  • for several files: yunohost service log service_name --log /var/log/service_name/service_name.log /var/log/service_name/service_name2.log --log_type file
  • for a systemd log: yunohost service log service_name --log service_name --log_type systemd
  • for both: yunohost service log service_name --log /var/log/service_name/service_name.log service_name --log_type file systemd

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.4.x milestone Jan 26, 2019

@alexAubin alexAubin merged commit b43a31b into YunoHost:stretch-unstable Jan 26, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kay0u kay0u deleted the kay0u:enh-add-systemd-logs-for-apps branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment