New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] app conflicting with itself during change_url #626

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
4 participants
@alexAubin
Copy link
Member

alexAubin commented Jan 24, 2019

The problem

As reported by @maniackcrudelis, apps might conflict with themselves when change_url is used :

Change the url from sous.domain.tld/path to sous.domain.tld/...
[...]
 yunohost cli - This url is not available or conflicts with the already installed app(s):
 * sous.domain.tld/path → WordPress (wordpress)

Solution

Add an optional ignore_app argument to _get_conflicting_apps for the change_url usecase.

PR Status

Not tested :s

How to test

Pull the branch and test to change the url of an app from /path to / for instance ... or /path to /path2

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.4.x milestone Jan 24, 2019

@Psycojoker
Copy link
Member

Psycojoker left a comment

LGTM

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Jan 24, 2019

I'm going to try it

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Jan 24, 2019

I ran a complete change_url test with package check, it works perfectly \o/
I'm going to run a full test, in order to be sure though.

EDIT: Full test without any regression \o/

@alexAubin alexAubin merged commit e293cdc into stretch-unstable Jan 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the ignore-self-conflict-during-change-url branch Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment