New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #548 #627

Merged
merged 3 commits into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Jan 24, 2019

The problem

#548 (comment)
It was a mistake to avoid the creation of the ini file.

Solution

Restore the code.
Print only a warning.

PR Status

Ready to be tested.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
Show resolved Hide resolved data/helpers.d/backend Outdated
@@ -222,7 +222,12 @@ ynh_add_fpm_config () {

if [ -e "../conf/php-fpm.ini" ]
then
echo "Please do not use a separate ini file, merge you directives in the pool file instead." &>2
echo "Please do not use a separate ini file, merge your directives in the pool file instead." >&2

This comment has been minimized.

@alexAubin

alexAubin Jan 24, 2019

Member

Shouldn't we add something in the package linter about the existence of this file ?

maniackcrudelis and others added some commits Jan 24, 2019

Print backup and restore logs into the upgrade log
Without --debug in upgrade command line, no more log will be printed in stdout.
Still the log will be added to the log file, and so will help to debug a backup in that case.
Update data/helpers.d/backend
Co-Authored-By: maniackcrudelis <maniackcrudelis@users.noreply.github.com>

@alexAubin alexAubin added this to the 3.4.x milestone Jan 26, 2019

@alexAubin alexAubin merged commit 661250d into stretch-unstable Jan 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix_do_not_use_phpini branch Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment