New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix home_dir unset in ynh_system_user_create #629

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Jan 27, 2019

The problem

ynh_system_user_create is failing with the error home_dir: unbound variable

Solution

Set home_dir if not used.

PR Status

Ready to be reviewed.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin
Copy link
Member

alexAubin left a comment

LGTM, can be merged as a microdecision ?

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Jan 28, 2019

Yep, can be, just a small fix

@alexAubin alexAubin merged commit 081d4b2 into stretch-unstable Jan 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the Fix_ynh_system_user_create branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment