Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Allow to dig deeper into an archive with ynh_setup_source #630

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Jan 27, 2019

The problem

Sometimes, you have to remove more than one sub-directory into an archive to get the app itself.
That's what's happens with dotclear2.

Solution

Allow to dig deeper than only one sub-directory with SOURCE_IN_SUBDIR

PR Status

Ready to be reviewed.
Tested with dotclear2 with SOURCE_IN_SUBDIR as true, false, 1 and 2.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@alexAubin
Copy link
Member

left a comment

LGTM, can be merged as microdecision ?

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

There's no need to hurry for this PR.
So we can merge, but if some want to have a look at it, we can wait.

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

@alexAubin alexAubin modified the milestones: 3.4.x, 3.5.x Jan 29, 2019

@alexAubin alexAubin merged commit 1b63012 into stretch-unstable Feb 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the ynh_setup_source_digs_deeper branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.