New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Do not log migration to stretch in /tmp/. Issue #1280 #632

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@opi
Copy link
Contributor

opi commented Jan 28, 2019

The problem

Log file will be erased at reboot. Sometimes the dist-upgrade process goes bad, and the server need a manual (and forced) reboot.

Solution

Use the /var/log/yunohost folder, which already exists.

How to test

Take a jessie server, install yunohost 2.x, launch the migration, crash your machine during migration, hard-reboot and see if a log file exists in /var/log/yunohost.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :
@Psycojoker
Copy link
Member

Psycojoker left a comment

LGTM, thx for this ❤️

@alexAubin
Copy link
Member

alexAubin left a comment

Yolomerging 👍

@alexAubin alexAubin merged commit 5817d80 into stretch-unstable Jan 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the 1280-do-not-log-migration-in-tmp branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment