Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ynh_script_progression #634
I know that this helper is brand new, 2 days only, but there's no real danger with it and I really would like to see it widely used by all apps. Especially official ones.
Add the wonderful new helper ynh_script_progression :D
Ready to be reviewed.
About the usage of this script : please note that it might not be relevant for backup and restore scripts !
For instance, the way backup happens is to run the backup script only to get the list of files to backup (modulo the mysql dump) but not to copy them yet. So the bulk of the execution time is expected to be after running all those script. In that case, what the use might see is :
And a similar thing (in reverse) happening when restoring
So I would not recommend using this helper during backup (though I havent tried to confirm the behavior). If there's a progress bar to be implemented for this, it should be implemented in the core during the actual copy I think...
There's actually other steps in backup and restore, especially restore script with reinstallation of dependencies, restart of services and other things like that which take time.