Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user that ynh_secure_remove should be used with only one arg… #635

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@alexAubin
Copy link
Member

commented Jan 29, 2019

The problem

This is a silly detail, but the mistake of calling ynh_secure_remove with more than one arg comes quickly ... Either because you transform a rm -rf /foo/* to ynh_secure_remove /foo/*, or rm foo bar into ynh_secure_remove foo bar

Solution

Add a small warning for the packager to tell that other arguments given will be ignored

PR Status

Not tested because laziness @.@

How to test

Try to run ynh_secure_remove with multiple args

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.5.x milestone Feb 5, 2019

@alexAubin alexAubin merged commit a82bbcb into stretch-unstable Feb 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the ynh-secure-remove-has-only-one-arg branch Feb 5, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

Warning: yunohost.hook <lambda> - [1003.1] /usr/share/yunohost/helpers.d/filesystem: line 351: $2: unbound variable

maniackcrudelis added a commit that referenced this pull request Feb 6, 2019

@maniackcrudelis maniackcrudelis referenced this pull request Feb 6, 2019

Merged

Fix #635 on ynh_secure_remove #642

0 of 4 tasks complete

alexAubin added a commit that referenced this pull request Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.