Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #635 on ynh_secure_remove #642

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Feb 6, 2019

The problem

#635 has added a regression by using $2 directly, which fails if there's only one argument.
/usr/share/yunohost/helpers.d/filesystem: line 351: $2: unbound variable

Solution

Use the number of args instead of testing $2
Anyway, by using getopts, we will already have a message like: Attention : [WARN] Too many arguments ! /my/path will be ignored.

PR Status

Tested with my new "personal" ynh-dev ;)

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

@maniackcrudelis maniackcrudelis requested a review from alexAubin Feb 6, 2019

@alexAubin alexAubin added this to the 3.5.x milestone Feb 6, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Merging as microdecision

@alexAubin alexAubin merged commit 65e1bc2 into stretch-unstable Feb 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the fix_ynh_secure_remove branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.