New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ynh_local_curl #644

Merged
merged 3 commits into from Feb 16, 2019

Conversation

Projects
None yet
3 participants
@kay0u
Copy link
Contributor

kay0u commented Feb 9, 2019

The problem

In some conditions, ynh_local_curl doesn't curl the right url

Solution

I'm ensure that the url is well formatted

PR Status

Tested

How to test

path_url=/test
ynh_local_curl index.php
path_url=/
ynh_local_curl index.php
path_url=/
ynh_local_curl /index.php

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

kay0u added some commits Feb 9, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Feb 10, 2019

Anyone from @YunoHost/apps can review this ?

Show resolved Hide resolved data/helpers.d/utils Outdated
@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Feb 10, 2019

Could you give an example of curl fetching the wrong url ?
All I can see in your code is to prevent a double slash after the path_url. Not sure though it's really a big deal.

@kay0u

This comment has been minimized.

Copy link
Contributor Author

kay0u commented Feb 11, 2019

Could you give an example of curl fetching the wrong url ?
All I can see in your code is to prevent a double slash after the path_url. Not sure though it's really a big deal.

dotclear

This app doesn't well configured with a double slash (Don't know why)

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Feb 11, 2019

LGTM, not tested though

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

maniackcrudelis commented Feb 15, 2019

@alexAubin alexAubin added this to the 3.5.x milestone Feb 15, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Feb 16, 2019

#Yolo

@alexAubin alexAubin merged commit d5ea18d into YunoHost:stretch-unstable Feb 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment