New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app debugger helper #647

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Feb 10, 2019

Just wrote this helper to help me debugging getopts. Figured it would be really useful for every packager while trying to debug an app.
This helper can simply print a message or a variable, marked as debug. But also trace a defined part of a script instead of simply using --debug while running an install.

As this helper isn't meant to be used permanently in app packages, I think we can't merge it quickly, so it will be easily available for debugging.

PR Status

Ready to be reviewed.

How to test

Try this helper in any app.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

@maniackcrudelis maniackcrudelis changed the title Create debug Add app debugger helper Feb 10, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Feb 15, 2019

Bump

This helper is really helpful.
If I could not copy it each time I need it, it would be wonderful ;)

@alexAubin alexAubin added this to the 3.5.x milestone Feb 15, 2019

@alexAubin
Copy link
Member

alexAubin left a comment

I guess it's fine though not sure to understand what this does ¯\_(ツ)_/¯

Any opinion from @YunoHost/apps people ?

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Feb 16, 2019

I mainly use that helper with --trace option, to trace only the part of the code I want to debug.
So, without modifying all lines of the code, I can see what's going on a specific part.
In opposition with --debug that print the entire code. Also, this helper works in package check.

@alexAubin alexAubin merged commit 10f3301 into stretch-unstable Feb 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the app_debugger branch Feb 19, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Feb 19, 2019

Thanks @alexAubin \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment