Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Print diff of files when backup by ynh_backup_if_checksum_is_different #648

Merged
merged 4 commits into from Feb 24, 2019

Conversation

Projects
None yet
2 participants
@maniackcrudelis
Copy link
Contributor

commented Feb 12, 2019

The problem

When ynh_backup_if_checksum_is_different backup a file because it was modified, an admin can't know easily what are the differences.

Solution

Print a diff of the differences between the previous file and the new one.

PR Status

Ready to be reviewed.

How to test

Change a config file, then upgrade the app.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@YunoHost/apps

maniackcrudelis added some commits Feb 12, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

Show resolved Hide resolved data/helpers.d/filesystem Outdated

@alexAubin alexAubin added this to the 3.5.x milestone Feb 15, 2019

@alexAubin
Copy link
Member

left a comment

LGTM

@alexAubin alexAubin changed the title Print diff of files when backup by ynh_backup_if_checksum_is_different [enh] Print diff of files when backup by ynh_backup_if_checksum_is_different Feb 19, 2019

@alexAubin alexAubin merged commit ec72a8d into stretch-unstable Feb 24, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the diff_backup_file branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.