Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Improve / add some messages to improve UX #650

Merged
merged 4 commits into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@alexAubin
Copy link
Member

commented Feb 16, 2019

The problem

Weird UX stuff, especially the "No app to upgrade" error when some app upgrade failed ... Also had this duplicate thing when just upgrading nextcloud :

Info: Upgrading apps nextcloud
Info: Upgrading app nextcloud…

Solution

Various tweaks to improve UX when dealing with app upgrades

PR Status

To be tested :D

How to test

Trigger some app upgrades with single or several apps, and also check what happens when an upgrade fails

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin added this to the 3.5.x milestone Feb 16, 2019

@alexAubin alexAubin changed the title App upgrade message ux [enh] Improve apps upgrade messages Feb 16, 2019

@Josue-T

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

Not directly related to this PR, but I think that adding a possibility to fore the upgrade even if the app is up to date, could be really useful in some cases.

@alexAubin alexAubin changed the title [enh] Improve apps upgrade messages [enh] Improve / add some messages to improve UX Feb 16, 2019

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2019

@Josue-T : so like a --force option which upgrades anyway ?

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

Great! Doing exactly this was on my to-do list so 👍 (I just can't correctly review right now)

@Josue-T

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

@Josue-T : so like a --force option which upgrades anyway ?

Yes

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

About the --force option for app upgrade, there's an issue already opened here : YunoHost/issues#33

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

Flagging this as ready to merge

@alexAubin alexAubin merged commit cfda8ac into stretch-unstable Feb 24, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the app_upgrade_message_ux branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.