Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Ensure the tar file is closed during the backup #655

Merged
merged 3 commits into from Feb 21, 2019

Conversation

Projects
None yet
3 participants
@kay0u
Copy link
Contributor

commented Feb 19, 2019

The problem

In some conditions during a backup, the tar file is not closed.

Solution

Ensure the tar file is closed

PR Status

...

How to test

...

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

kay0u added some commits Feb 19, 2019

@alexAubin
Copy link
Member

left a comment

LGTM 👍

@zamentur
Copy link
Contributor

left a comment

LGTM

@alexAubin alexAubin merged commit 7e37833 into YunoHost:stretch-unstable Feb 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kay0u kay0u deleted the kay0u:patch-4 branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.